Skip to content

feat(telemetry): Include user intent for copy and insert code interactions #4903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 25, 2024
Merged

feat(telemetry): Include user intent for copy and insert code interactions #4903

merged 5 commits into from
Sep 25, 2024

Conversation

@lalexcaws
Copy link
Contributor

@lalexcaws lalexcaws commented Sep 23, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Adding User Intent to copy code and insert code at cursor interaction telemetry data
[Why] This will be part of an effort to capture metrics on how often each interaction type is occurring when the user intent is related to unit test generation

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lalexcaws lalexcaws requested a review from a team as a code owner September 23, 2024 17:21
@rli
Copy link
Contributor

rli commented Sep 23, 2024 

> Task :plugin-amazonq:chat:jetbrains-community:compileKotlin
e: file:///codebuild/output/src152308433/src/github.com/aws/aws-toolkit-jetbrains/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt:213:21 Cannot find a parameter with this name: cwsprChatUserIntent
e: file:///codebuild/output/src152308433/src/github.com/aws/aws-toolkit-jetbrains/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt:237:21 Cannot find a parameter with this name: cwsprChatUserIntent
Finished executing kotlin compiler using DAEMON strategy

> Task :plugin-amazonq:chat:jetbrains-community:compileKotlin FAILED

@lalexcaws lalexcaws requested a review from a team as a code owner September 24, 2024 11:49
rli
rli approved these changes Sep 24, 2024
View reviewed changes
plugins/core/jetbrains-community/resources/telemetryOverride.json
Comment on lines +656 to +659
{
"type": "cwsprChatUserIntent",
"required": false
},
Copy link
Contributor

@rli rli Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be pushing this into the common definitions

Copy link
Contributor Author

@lalexcaws lalexcaws Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, this was mentioned in my VSCode plugin change as well. Going to get out that change

@laileni-aws
Copy link
Contributor

laileni-aws commented Sep 24, 2024

/retryBuilds

@lalexcaws
Copy link
Contributor Author

lalexcaws commented Sep 25, 2024

Commons definition update: aws/aws-toolkit-common#864

@rli
Copy link
Contributor

rli commented Sep 25, 2024

can you do a follow-up to remove the override and use the common definition?

@rli rli merged commit e10d880 into aws:main Sep 25, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rli rli rli approved these changes

@laileni-aws laileni-aws laileni-aws approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lalexcaws @rli @laileni-aws